Merge branch 'master' of git.alternc.org:alternc

.gitattributes

@@ -615,7 +615,6 @@ roundcube/class/m_roundcube.php -text
 roundcube/roundcube-install -text
 roundcube/roundcube_alternc_logo.png -text
 roundcube/templates/apache2/roundcube.conf -text
-roundcube/templates/logrotate.d/roundcube-core -text
 roundcube/templates/roundcube/main.inc.php -text
 roundcube/templates/roundcube/plugins/managesieve/config.inc.php -text
 roundcube/templates/roundcube/plugins/password/config.inc.php -text

bureau/admin/hta_del.php

@@ -35,11 +35,12 @@ reset($_POST);
 while (list($key,$val)=each($_POST)) {
 	if (substr($key,0,4)=="del_") {
 		// Effacement du dossier $val
-		$r=$hta->DelDir($val);
-		if (!$r) {
-			$error.=$err->errstr()."<br />";
+//		$r=$hta->DelDir($val);
+		$return = $hta->DelDir($val);
+		if (!$return) {
+			$error.= $err->errstr()."<br />";
 		} else {
-			$error.=sprintf(_("The protected folder %s has been successfully unprotected"),$val)."<br />";
+			$error.= sprintf(_("The protected folder %s has been successfully unprotected"),$val)."<br />";
 		}
 	}
 }

phpunit/bootstrap.php

@@ -156,4 +156,4 @@ $mem                                    = new \m_mem();
 $err                                    = new \m_err();
 $authip                                 = new \m_authip();
 $hooks                                  = new \m_hooks();
-
+$bro                                    = new \m_bro();

phpunit/tests/bureau/class/m_htaTest.php

@@ -9,6 +9,9 @@ class m_htaTest extends PHPUnit_Framework_TestCase
      */
     protected $object;
 
+    const PATH_HTACCESS             = "/tmp/.htaccess";
+    const PATH_HTPASSWD             = "/tmp/.htpasswd";
+    
     /**
      * Sets up the fixture, for example, opens a network connection.
      * This method is called before a test is executed.
@@ -16,6 +19,10 @@ class m_htaTest extends PHPUnit_Framework_TestCase
     protected function setUp()
     {
         parent::setUp();
+        touch(self::PATH_HTACCESS);
+        touch(self::PATH_HTPASSWD);
+        $file_content = "AuthUserFile \"/tmp/.htpasswd\"\nAuthName \"Restricted area\"\nAuthType Basic\nrequire valid-user\n";
+        file_put_contents(self::PATH_HTACCESS,$file_content);
         $this->object = new m_hta;
     }
 
@@ -26,6 +33,12 @@ class m_htaTest extends PHPUnit_Framework_TestCase
     protected function tearDown()
     {
         parent::tearDown();
+        if(file_exists(self::PATH_HTACCESS)){
+            unlink (self::PATH_HTACCESS);
+        }
+        if(file_exists(self::PATH_HTPASSWD)){
+            unlink (self::PATH_HTPASSWD);
+        }
     }
 
     /**
@@ -114,14 +127,26 @@ class m_htaTest extends PHPUnit_Framework_TestCase
 
     /**
      * @covers m_hta::DelDir
-     * @todo   Implement testDelDir().
      */
     public function testDelDir()
     {
-        // Remove the following lines when you implement this test.
-        $this->markTestIncomplete(
-          'This test has not been implemented yet.'
-        );
+        $result                             = $this->object->DelDir("/tmp",TRUE);
+        $this->assertTrue($result);
+        $this->assertFileNotExists(self::PATH_HTACCESS);
+        $this->assertFileNotExists(self::PATH_HTPASSWD);
+    }
+
+    /**
+     * @covers m_hta::DelDir
+     */
+    public function testDelDirNotEmpty()
+    {
+        file_put_contents(self::PATH_HTACCESS, "\nphpunit", FILE_APPEND);
+        $result                             = $this->object->DelDir("/tmp",TRUE);
+        $this->assertTrue($result);
+        $this->assertFileExists(self::PATH_HTACCESS);
+        $this->assertFileNotExists(self::PATH_HTPASSWD);
+        $this->assertTrue("phpunit" == trim(file_get_contents(self::PATH_HTACCESS)));
     }
 
     /**

roundcube/roundcube-install

@@ -28,7 +28,7 @@ then
 #    cp -f /etc/alternc/templates/roundcube/avelsieve-config.php /etc/alternc/templates/roundcube/apache.conf /etc/roundcube/
 #    cp -f /etc/alternc/templates/javascript-common/javascript-common.conf /etc/javascript-common/
 
-    LOGIN="2000_roundcube"
+    LOGIN="0000_roundcube"
     PASSWORD="`perl -e 'print map{("a".."z","A".."Z",0..9)[int(rand(62))]}(1..10)'`"
     DESKEY="`perl -e 'print map{("a".."z","A".."Z",0..9)[int(rand(62))]}(1..24)'`"
 
@@ -40,7 +40,6 @@ then
     # Configuration template location
     TEMPLATE_DIR="/etc/alternc/templates"
     CONFIG_FILES="etc/roundcube/main.inc.php etc/roundcube/plugins/password/config.inc.php etc/roundcube/plugins/managesieve/config.inc.php"
-    LOGROTATE_FILES="etc/logrotate.d/roundcube-core"
 
     cat > $SED_SCRIPT <<EOF
 s\\%%ALTERNC_LOC%%\\$ALTERNC_LOC\\;
@@ -62,14 +61,6 @@ EOF
 
     echo "    Done"
 
-    for file in $LOGROTATE_FILES; do
-        TEMPLATE="$TEMPLATE_DIR/${file##etc/}"
-        echo -n " $file"
-        if [ -f "$TEMPLATE" ]; then
-            cat $TEMPLATE > /$file
-        fi
-    done
-
     echo "    Done"
 
     . /usr/lib/alternc/functions.sh
@@ -99,10 +90,3 @@ EOF
     
 fi
 
-#This is necessary because upgrading roundcube from 7.1 to 7.2 changes this setting
-if [ "$1" = "end" ]; then
-  chown alternc-roundcube:root /etc/roundcube/main.inc.php
-fi
-
-
-

roundcube/templates/apache2/roundcube.conf

 <VirtualHost *:80>
   ServerName %%fqdn%%
-  AssignUserId alternc-roundcube nogroup
-  SetEnv LOGIN "%%UID%%-%%LOGIN%%"
+  AssignUserId www-data www-data
+  SetEnv LOGIN "0000-roundcube"
 
   DocumentRoot /var/lib/roundcube
 
-# Access to tinymce files
-<Directory "/usr/share/tinymce/www/">
-      Options Indexes MultiViews FollowSymLinks
-      AllowOverride None
-      Order allow,deny
-      allow from all
-</Directory>
-
-<Directory /var/lib/roundcube/>
-  Options +FollowSymLinks
-  # This is needed to parse /var/lib/roundcube/.htaccess. See its
-  # content before setting AllowOverride to None.
-  AllowOverride All
-  order allow,deny
-  allow from all
-</Directory>
-
-# Protecting basic directories:
-<Directory /var/lib/roundcube/config>
-        Options -FollowSymLinks
+  # Access to tinymce files
+  <Directory "/usr/share/tinymce/www/">
+        Options Indexes MultiViews FollowSymLinks
         AllowOverride None
-</Directory>
+        Order allow,deny
+        allow from all
+  </Directory>
 
-<Directory /var/lib/roundcube/temp>
-        Options -FollowSymLinks
-        AllowOverride None
-	Order allow,deny
-	Deny from all
-</Directory>
+  <Directory /var/lib/roundcube/>
+    Options +FollowSymLinks
+    # This is needed to parse /var/lib/roundcube/.htaccess. See its
+    # content before setting AllowOverride to None.
+    AllowOverride All
+    order allow,deny
+    allow from all
+  </Directory>
 
-<Directory /var/lib/roundcube/logs>
-        Options -FollowSymLinks
-        AllowOverride None
-	Order allow,deny
-	Deny from all
-</Directory>
+  # Protecting basic directories:
+  <Directory /var/lib/roundcube/config>
+    Options -FollowSymLinks
+    AllowOverride None
+  </Directory>
+
+  <Directory /var/lib/roundcube/temp>
+    Options -FollowSymLinks
+    AllowOverride None
+    Order allow,deny
+    Deny from all
+  </Directory>
+
+  <Directory /var/lib/roundcube/logs>
+    Options -FollowSymLinks
+    AllowOverride None
+    Order allow,deny
+    Deny from all
+  </Directory>
 
   Alias /javascript /usr/share/javascript/
 

roundcube/templates/logrotate.d/roundcube-core

-######
-# Configuration file of Roundcube's logrotate for AlternC
-#
-# /!\ WARNING /!\ Do not edit this file, edit the one in
-# /etc/alternc/templates/logrotate.d/ and launch alternc.install again.
-######
-
-/var/log/roundcube/password /var/log/roundcube/errors /var/log/roundcube/sendmail /var/log/roundcube/userlogins {
-  create 0640 alternc-roundcube root 
-  compress
-  missingok
-  notifempty
-  rotate 52
-  weekly
-}