GitLab

[bug] Augeas is still needed

Without including `augeas` puppet would complain:

    Error: Could not find resource 'Class[Augeas]' for relationship on
    'Class[Shorewall::Base]' on node default

See merge request !6

Without including `augeas` puppet would complain:

    Error: Could not find resource 'Class[Augeas]' for relationship on
    'Class[Shorewall::Base]' on node default

Immerda changes



See merge request !5

Remove 'require augeas' (#4396)

Because the puppet 'require' keyword actually instantiates a class,
having 'require augeas' in base.pp means that you cannot instantiate the
augeas class anywhere else in your manifests, for example with some
optional parameters to the class. If you do, you will get a duplicate
definition error.

The README already says that the augeas module is required. It seems
better that this is managed outside of the module, allowing for
class parameter flexibility.

See merge request !3

Feature/mangle support multiple rules with same action

This allows one to support multiple networks in libvirt.

See merge request !4

That is, make the resource's title more unique by including the destination
interface in it, and accordingly pass the desired action via the new,
dedicated parameter.

Previously, it was using $name, which prevented adding multiple mangle
rules that share a common ACTION, with different parameters.

Because the puppet 'require' keyword actually instantiates a class,
having 'require augeas' in base.pp means that you cannot instantiate the
augeas class anywhere else in your manifests, for example with some
optional parameters to the class. If you do, you will get a duplicate
definition error.

The README already says that the augeas module is required. It seems
better that this is managed outside of the module, allowing for
class parameter flexibility.