GitLab

Checking whether an exported resource is already defined
at backupninja::server::sandbox, otherwise puppet will try
to redefined them each time a backup resource type is invoked
with the same arguments (such as $directory), raising an error.

fix rdiff-backup class name, "You can use Aa-Zz, 0-9 and underscores in variables, resources and class names." which means no dashes in class names either

remove redundant case statements which tested to see if the package ensure version variables were set
changed the $rdiff-backup_ensure_version variable to $rdiff_backup_ensure_version as dashes are not allowed in variable names

create subclasses for maildir and rdiff-backup. If you are using these features of backupninja, you'll want to switch to doing "include backupninja::client::maildir" for the machines that need it and this will pull in backupninja::client, so you don't need to include that anymore if you were explicitly doing so for those machines (although it shouldn't hurt). Right now what using these new subclasses will get you is dependencies on needed packages, but in the future there might be more.

remove the versioncmp function in the rdiff handler. This was a nice attempt to try and support older
puppets, but this functionality has not stabilized yet, 0.24.8 broke versioncmp and there looks like
a new way coming. Its easier to be mean.

set into the rdiff config, so 'sshoptions = false' which results in the
host attempting to connect to a hostname called 'false'.

This change only includes it if the value is not 'false'.

If when is set to just '01:00' (as it was previously), then backups
will never run due to the time format being specified
incorrectly. Backupninja considers '01:00' to be the day of the week
and every time it wakes up to see if it is time to do a backup it
determines that it is currently not the day "01:00" and so it
shouldn't do a backup now. In otherwords, it will never do a backup at
this rate.

I've filed a bug for this issue, because it probably should at least
let you know that you've failed.

    https://labs.riseup.net/code/issues/show/640

Change to the new format required in templates now that scope is no longer availble in templates since
0.24.6:
http://projects.reductivelabs.com/issues/show/1177

this handler runs continuously its better if all the other handlers
have run before this one is started (such as the rdiff-backup one)