neutrinet_ynh issueshttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues2023-03-15T08:09:40Zhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/32Git detected dubious ownership in repository2023-03-15T08:09:40ZHgOGit detected dubious ownership in repositoryThere is an error when trying to upgrade with a recent version of git:
```
ERROR The operation 'Upgrade the 'neutrinet' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 202303...There is an error when trying to upgrade with a recent version of git:
```
ERROR The operation 'Upgrade the 'neutrinet' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20230301-204532-app_upgrade-neutrinet' to get help
```
See also Yunohost CI : https://ci-apps.yunohost.org/ci/job/13962
We just need to fix ownership…HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/27super-old deprecated packaging practices ?2022-04-09T16:59:54ZThierry Fenassesuper-old deprecated packaging practices ?```
=================================
Applications (apps)
=================================
[ERROR] An issue was found for app Neutrinet
- This app's installed version still uses some super-old deprecated packaging practices. You shou...```
=================================
Applications (apps)
=================================
[ERROR] An issue was found for app Neutrinet
- This app's installed version still uses some super-old deprecated packaging practices. You should really consider upgrading it.
```
C'est le truc de diagnostic de Yunohost qui dit ça…https://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/19Package check tool2022-04-09T14:43:00ZHgOPackage check toolIt would be really nice to use the [package check](https://github.com/YunoHost/package_check) tool provided by Yunohost. We can define a number of unit tests to check if the package is behaving correctly.
There is also a CI server that...It would be really nice to use the [package check](https://github.com/YunoHost/package_check) tool provided by Yunohost. We can define a number of unit tests to check if the package is behaving correctly.
There is also a CI server that would let us automatically check the app for each MR : https://yunohost.org/#/packaging_apps_cihttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/31Change url in manifest to upstream url2022-04-09T14:40:09ZHgOChange url in manifest to upstream urlAccording to the linter, the `url` keyword in the manifest.json should be the upstream app urlAccording to the linter, the `url` keyword in the manifest.json should be the upstream app urlHgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/30Suppress warnings when cloning the renew-cert repo2022-04-09T14:40:09ZHgOSuppress warnings when cloning the renew-cert repoHgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/28Add category to apps.json2022-01-15T19:40:42ZIljaAdd category to apps.jsonWe can add a category to our app, which will fix a warning in the package_check.
Here I chose `system_tools` with a subtag `monitoring` since the main goal of the app is to monitor (and update when needed) the vpn certificates. To have ...We can add a category to our app, which will fix a warning in the package_check.
Here I chose `system_tools` with a subtag `monitoring` since the main goal of the app is to monitor (and update when needed) the vpn certificates. To have it, make a PR to the apps repo at <https://github.com/YunoHost/apps/>. I tried, but can't push and rather not have a category than having to please github's latest tantrums.
This is the diff
```
diff --git a/apps.json b/apps.json
index c7bfa80..241938b 100644
--- a/apps.json
+++ b/apps.json
@@ -2138,9 +2138,13 @@
"url": "https://github.com/YunoHost-Apps/netdata_ynh"
},
"neutrinet": {
+ "category": "system_tools",
"branch": "stable",
"level": 6,
"state": "working",
+ "subtags": [
+ "monitoring"
+ ],
"url": "https://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh"
},
"nextcloud": {
```HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/26Fix MTU for OpenVPN client2021-10-09T19:19:50ZHgOFix MTU for OpenVPN clientshould add `mssfix 1400` in the vpnclient app settingsshould add `mssfix 1400` in the vpnclient app settingsHgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/25Add Yunohost pipeline status icons in the ReadMe2020-12-12T17:20:03ZHgOAdd Yunohost pipeline status icons in the ReadMeExample: https://github.com/YunoHost-Apps/dokuwiki_ynh/blob/testing/README.md
For Neutrinet, this would give the following:
[![Integration level](https://dash.yunohost.org/integration/neutrinet.svg)](https://dash.yunohost.org/appci/app...Example: https://github.com/YunoHost-Apps/dokuwiki_ynh/blob/testing/README.md
For Neutrinet, this would give the following:
[![Integration level](https://dash.yunohost.org/integration/neutrinet.svg)](https://dash.yunohost.org/appci/app/neutrinet) [![](https://ci-apps.yunohost.org/ci/badges/neutrinet.status.svg)](https://ci-apps.yunohost.org/ci/badges/neutrinet.status.svg) [![](https://ci-apps.yunohost.org/ci/badges/neutrinet.maintain.svg)](https://ci-apps.yunohost.org/ci/badges/neutrinet.maintain.svg)
[![Install DokuWiki with YunoHost](https://install-app.yunohost.org/install-with-yunohost.png)](https://install-app.yunohost.org/?app=neutrinet)Neutrinet v0.3.1~ynh3HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/22Depreciation of yunocube scripts2020-12-12T17:00:33ZHgODepreciation of yunocube scriptsApparently, La Brique Internet will change the way they build the images. Instead of [a script that builds a Yunohost image](https://github.com/labriqueinternet/build.labriqueinter.net), they will provide their own image : https://github...Apparently, La Brique Internet will change the way they build the images. Instead of [a script that builds a Yunohost image](https://github.com/labriqueinternet/build.labriqueinter.net), they will provide their own image : https://github.com/YunoHost/arm-images
I'm not sure what's the status of this project, or when would the yunocube scripts become obsolete...
But I think we should have a look on this as this could affect our own script.
According to these [PR comments](https://github.com/labriqueinternet/build.labriqueinter.net/pull/70#issuecomment-623019265), we could get more information this Monday.https://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/18App list apps.json vs stable2020-12-05T17:02:01ZIljaApp list apps.json vs stableThe Neutrinet application list is now at https://apps.neutrinet.be/stable, but the README.md still says https://neutrinet.be/apps.json
I assume this should be changed? HOWEVER we can't just change it because the FE requires the URL to e...The Neutrinet application list is now at https://apps.neutrinet.be/stable, but the README.md still says https://neutrinet.be/apps.json
I assume this should be changed? HOWEVER we can't just change it because the FE requires the URL to end in .json (not sure about CLI)
![image](/uploads/97c1c1088e2321f834a5fde9994618c8/image.png)
Adding https://neutrinet.be/apps.json does still work, so we can just leave it as it is (and maybe that was already the idea, idk)IljaIljahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/21Which license do we choose ?2020-12-05T16:57:46ZHgOWhich license do we choose ?As the Yunohost's CI tool requires a license for the app, I guess it's time to think about this.
In the manifest, the GPL3.0 is mentionned. However, I would go for AGPL as this is a web service. But if we don't really care, we could go ...As the Yunohost's CI tool requires a license for the app, I guess it's time to think about this.
In the manifest, the GPL3.0 is mentionned. However, I would go for AGPL as this is a web service. But if we don't really care, we could go for the [BeerWare](https://fr.wikipedia.org/wiki/Beerware) license? (although I would prefer a non-alcoholic license ^^)
What are your thoughts / preferences about this ?https://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/23Install procedure is misleading for ynh 3.82020-12-05T16:56:40ZThierry FenasseInstall procedure is misleading for ynh 3.8I tried what is proposed on the readme (web or cli) but I was not able to install the app.
From the web, there is no more tools > advanced > applications…
![image](/uploads/7a274690d3a845b55df92074a229be41/image.png)
From the cli, the...I tried what is proposed on the readme (web or cli) but I was not able to install the app.
From the web, there is no more tools > advanced > applications…
![image](/uploads/7a274690d3a845b55df92074a229be41/image.png)
From the cli, there is no more « listlists »
```
# yunohost app listlists
usage: yunohost app
{catalog,fetchlist,list,info,map,install,remove,upgrade,change-url,setting,register-url,makedefault,ssowatconf,change-label,addaccess,removeaccess,clearaccess,action,config}
...
[-h]
yunohost app: error: invalid choice: 'listlists' (choose from 'catalog', 'fetchlist', 'list', 'info', 'map', 'install', 'remove', 'upgrade', 'change-url', 'setting', 'register-url', 'makedefault', 'ssowatconf', 'change-label', 'addaccess', 'removeaccess', 'clearaccess', 'action', 'config')
```
Or the app fetchlist does not work anymore
```
# yunohost app fetchlist --name neutrinet -u https://neutrinet.be/apps.json
Warning: 'yunohost app fetchlist' is deprecated and will be removed in the future
usage: yunohost
{user,domain,app,backup,settings,service,firewall,dyndns,tools,hook,log,diagnosis}
...
[-h] [--no-cache] [--output-as {json,plain,none}] [--debug]
[--quiet] [--timeout ==SUPPRESS==] [--admin-password PASSWORD]
[-v]
yunohost: error: unrecognized arguments: --name neutrinet -u https://neutrinet.be/apps.json
```https://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/17error on installation2020-05-09T10:53:41ZThierry Fenasseerror on installationHere is the log.
It's a lime2 with ynh 3.7.1
https://paste.yunohost.org/raw/uyogeqemaqHere is the log.
It's a lime2 with ynh 3.7.1
https://paste.yunohost.org/raw/uyogeqemaqhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/20Certificate renewal hotfix release2020-05-03T11:06:40ZHgOCertificate renewal hotfix releaseI already started some testing in !30
In short, we have a bug that occurs when a certificate is renewed:
- The common name (CN) was set to `certificate for <email>` before the refactoring of the renew_cert script last autumn.
- Since w...I already started some testing in !30
In short, we have a bug that occurs when a certificate is renewed:
- The common name (CN) was set to `certificate for <email>` before the refactoring of the renew_cert script last autumn.
- Since we released the new script, the CN is now set to `<email>`
- However, our VPN server doesn't like that kind of change, and can suddenly think that we introduced a new client with IPv6 only...
We are still not sure when this bug occurs exactly, but the fix is to take the CN from the VPN server. We first take the CN from the first IPv4 client, otherwise we take it from the first IPv6-only client, otherwise it is set to `<email>`.
We are waiting for the merge of https://gitlab.domainepublic.net/Neutrinet/renew_cert/-/merge_requests/3, but we could work on some improvement already. For instance, there will be new flags, such as `--quiet` that should be used in the cron job.HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/16Move master -> stable and develop -> unstable2020-03-01T20:52:26ZHgOMove master -> stable and develop -> unstable* [x] Create new branches (stable and unstable)
* [x] Freeze old branches (master and develop) so that nobody can merge there
* [x] Update documentation about contributing (change branch name)
* [x] On next release, change the target bra...* [x] Create new branches (stable and unstable)
* [x] Freeze old branches (master and develop) so that nobody can merge there
* [x] Update documentation about contributing (change branch name)
* [x] On next release, change the target branch in the apps list (see https://gitlab.domainepublic.net/Neutrinet/apps/issues/2)
* [x] Once everything is done, delete old branchNeutrinet v0.3.0~ynh5HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/15Add script to move domain/path2020-02-29T11:21:54ZIljaAdd script to move domain/pathThis is probably nothing more than changing the nginx file. Technically people can uninstall and install on the new domain/path, but having a script to move will be quicker/easier for the user.This is probably nothing more than changing the nginx file. Technically people can uninstall and install on the new domain/path, but having a script to move will be quicker/easier for the user.Neutrinet v0.3.0~ynh5HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/13Improve /neutrinet webpage2020-02-29T11:21:54ZIljaImprove /neutrinet webpage1. The links are now in bold. This isn't a typical thing to do, so it's not intuitive. These should be either another colour or underlined. Since Neutrinet doesn't really have a 'main' colour, I'd use underlined instead of bold.
2. There...1. The links are now in bold. This isn't a typical thing to do, so it's not intuitive. These should be either another colour or underlined. Since Neutrinet doesn't really have a 'main' colour, I'd use underlined instead of bold.
2. There is Javascript loaded which isn't used. It looks like this was part of a framework-like thing together with the css. The Javascript should be removed.
3. Add a translations for Dutch. The prefered way is probably to have a second page for Dutch and a link on the pages to switch from fr to nl. The default an remain fr.
* If this proves too difficult, maybe it can be easier to have both translations on one page (but let's try to not go this way).
* If this doesn't prove to be difficult enough, we can also see if we can have nginx load the nl/fr page in case nl/fr preference is detected from the browser. Fr should still be default.Neutrinet v0.3.0~ynh5IljaIljahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/14Add way to add list and install from Admin-interface2020-02-29T11:21:53ZIljaAdd way to add list and install from Admin-interfaceWe removed this from the readme because we couldn't add a list from the admin interface any more, but I think it just moved to somewhere else. Check it and add to readme.We removed this from the readme because we couldn't add a list from the admin interface any more, but I think it just moved to somewhere else. Check it and add to readme.Neutrinet v0.3.0~ynh5HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/10Use Yunohost progress bar2020-02-29T11:21:53ZHgOUse Yunohost progress barThat'd be very cool to use the Yunohost helper `ynh_script_progression` that displays a progress bar during the install / upgrade :smiley_cat:
If we go for it, we'll have to update the min requirements to Yunohost v3.5.0 in the `manife...That'd be very cool to use the Yunohost helper `ynh_script_progression` that displays a progress bar during the install / upgrade :smiley_cat:
If we go for it, we'll have to update the min requirements to Yunohost v3.5.0 in the `manifest.json`Neutrinet v0.3.0~ynh5HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_ynh/-/issues/7Cannot checkout renew_cert 0.3.02020-02-16T14:27:21ZHgOCannot checkout renew_cert 0.3.0I tried upgrading the Neutrinet app on my own cube, but I got this error :
```
Info: Installing automatic VPN certificate renewal...
Warning: error: pathspec '0.3.0' did not match any file(s) known to git.
Warning: [ERR] !!
Warning: n...I tried upgrading the Neutrinet app on my own cube, but I got this error :
```
Info: Installing automatic VPN certificate renewal...
Warning: error: pathspec '0.3.0' did not match any file(s) known to git.
Warning: [ERR] !!
Warning: neutrinet's script has encountered an error. Its execution was cancelled.
Warning: !!
Warning: Please find here an extract of the log before the crash:
Warning: [DEBUG]: DEBUG - ++ cut -d '~' -f 1
Warning: [DEBUG]: DEBUG - + renew_cert_version=0.3.0
Warning: [DEBUG]: DEBUG - + renew_cert_path=/opt/neutrinet/renew_cert
Warning: [DEBUG]: DEBUG - + renew_cert_virtualenv=/opt/neutrinet/renew_cert/ve
Warning: [DEBUG]: DEBUG - + renew_cert_python=/opt/neutrinet/renew_cert/ve/bin/python3
Warning: [DEBUG]: DEBUG - + renew_cert_cron_script=renew_cert_cron.sh
Warning: [DEBUG]: DEBUG -
Warning: [DEBUG]: DEBUG - + git -C /opt/neutrinet/renew_cert checkout 0.3.0
Warning: [DEBUG]: DEBUG - + ynh_exit_properly
Warning: [ERR] Upgrade failed.
Warning:
Error: Unable to upgrade neutrinet
```
Maybe we should do a `git pull` before?HgOHgO