neutrinet_cube_install merge requestshttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests2020-05-17T12:01:32Zhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/39Release changes for Install Party 17/05/20202020-05-17T12:01:32ZHgORelease changes for Install Party 17/05/2020## Release notes
- Make the hotspot install optional (!34 and !36)
- Remove Neutrinet custom apps list and use default Yunohost apps list (!38)
- Upgrade Internet Cube scripts and rebuild Yunohost image (!37)
- Remove copy/paste VPN cer...## Release notes
- Make the hotspot install optional (!34 and !36)
- Remove Neutrinet custom apps list and use default Yunohost apps list (!38)
- Upgrade Internet Cube scripts and rebuild Yunohost image (!37)
- Remove copy/paste VPN certificates feature (!32)
- Improve help for VPN certificates import (!32)
## Testing
- [x] Check that the hotspot is not installed when we choose to disable it
- [x] Check that the latest version of Neutrinet app is installed
- [x] Check the VPN certificates importInstall Party 17/05/2020https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/38Change Yunohost apps list2020-05-16T14:30:10ZHgOChange Yunohost apps listRelated to #34Related to #34Install Party 17/05/2020HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/37Upgrade yunocube scripts and rebuild Yunohost image2020-05-16T14:30:10ZHgOUpgrade yunocube scripts and rebuild Yunohost imageCloses #35
Blocking !36
* [x] Translate strings when !36 is mergedCloses #35
Blocking !36
* [x] Translate strings when !36 is mergedInstall Party 17/05/2020HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/36Add option to disable hotspot2020-05-17T08:52:25ZsohkaAdd option to disable hotspotCloses #33
[As suggested](https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/34#note_2680) by @HgO, I added an option to skip the installation of the hotspot (since it is now supported in the `hypercub...Closes #33
[As suggested](https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/34#note_2680) by @HgO, I added an option to skip the installation of the hotspot (since it is now supported in the `hypercube.sh` file).
~~Todo : add translations for the new messages.~~sohkasohkahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/35Bump build.labriqueinter.net repo for fixing cube install2020-05-09T13:44:14ZsohkaBump build.labriqueinter.net repo for fixing cube installThe previous bump of the build.labriqueinter.net repo broke the cube installation. For more details, see [this PR](https://github.com/labriqueinternet/build.labriqueinter.net/pull/73)The previous bump of the build.labriqueinter.net repo broke the cube installation. For more details, see [this PR](https://github.com/labriqueinternet/build.labriqueinter.net/pull/73)Install Party 17/05/2020sohkasohkahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/34Resolve "Make the hotspot install optional"2020-05-16T14:30:09ZsohkaResolve "Make the hotspot install optional"Closes #33Closes #33Install Party 17/05/2020sohkasohkahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/33Fix link to Neutrinet package list2020-04-04T22:20:47ZsohkaFix link to Neutrinet package listCloses #31Closes #31Install Party 17/05/2020sohkasohkahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/32Resolve "Improve certificates import (again)"2020-05-16T14:30:10ZHgOResolve "Improve certificates import (again)"Closes #25Closes #25Install Party 17/05/2020https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/31Resolve "Change link to Neutrinet package list"2020-04-03T19:11:21ZHgOResolve "Change link to Neutrinet package list"Closes #31Closes #31Install Party 17/05/2020HgOHgOhttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/30Update hypercube.sh script2020-04-04T00:35:03ZsohkaUpdate hypercube.sh scriptCloses #32
As explained in the related ticket, this MR just update the revision number of [build.labriqueinter.net](https://github.com/labriqueinternet/build.labriqueinter.net/) git repository to get the last change of the `hypercube...Closes #32
As explained in the related ticket, this MR just update the revision number of [build.labriqueinter.net](https://github.com/labriqueinternet/build.labriqueinter.net/) git repository to get the last change of the `hypercube.sh` script.Install Party 17/05/2020sohkasohkahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/29Release changes for install party on 16/02/20202020-02-16T13:10:16ZHgORelease changes for install party on 16/02/2020# Release notes
* Ignore verification of Yunohost GPG signature when the key import fails (!25, closes #21)
* Add the `-c` flag to include user's custom script (!24, closes #19)
* Remove the question about adding user's custom scrip...# Release notes
* Ignore verification of Yunohost GPG signature when the key import fails (!25, closes #21)
* Add the `-c` flag to include user's custom script (!24, closes #19)
* Remove the question about adding user's custom script (!24, closes #19)
* Fix incorrect password limits for Yunohost (!27, closes #23)
* Include Neutrinet specifics in general script (!23, closes #20)
* Update documentation about downloading the script (!28, closes #26)
* Fix issues with the cleanup when aborting (!26, closes #24)
# Testing
* [x] Check that resources are removed after cleanup, even when running the script from another directory (cube_resources and install.hypercube should be removed)
* [x] Check the `-c` flag :
* [x] Can include user's custom script
* [x] When the file doesn't exist, produce a warning and doesn't add ANY custom script (i.e. no Neutrinet specifics)
* [x] Check the password limits
* [x] Cannot enter a password < 8 chars
* [x] Can successfully install with passwords == 8 chars
* [ ] Check French translations
* [x] Check download instructions in the documentation
* [x] Check that the install succeed ^^Install Party 16/02/2020https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/28Documentation about downloading the script2020-02-09T09:22:01ZHgODocumentation about downloading the scriptCloses #26Closes #26Install Party 16/02/2020https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/27fix password min length2020-02-08T12:55:58ZHgOfix password min lengthCloses #23
So, because the [hypercube.sh](https://github.com/labriqueinternet/build.labriqueinter.net/blob/master/script/hypercube/hypercube.sh#L355) script doesn't use the `--force-password` flag, Yunohost uses additional checks to val...Closes #23
So, because the [hypercube.sh](https://github.com/labriqueinternet/build.labriqueinter.net/blob/master/script/hypercube/hypercube.sh#L355) script doesn't use the `--force-password` flag, Yunohost uses additional checks to validate the password. Those checks are done in [this class](https://github.com/YunoHost/yunohost/blob/stretch-unstable/src/yunohost/utils/password.py).
In short, they define a strength for the password
```
defined as a tuple containing the length of the password,
the number of digits, lowercase letters, uppercase letters,
and other characters.
For instance, "PikachuDu67" is (11, 2, 7, 2, 0)
```
Then, they compare the password strength to a list of strengths, from the weakest to the strongest. The minimum strength of an admin password (and an user password) is defined in the file [/etc/yunohost/settings.json](https://github.com/YunoHost/yunohost/blob/stretch-unstable/src/yunohost/settings.py#L60).
We can see there that it's the minimum level that is required, which means [(8, 0, 0, 0, 0)](https://github.com/YunoHost/yunohost/blob/stretch-unstable/src/yunohost/utils/password.py#L35), that is, a minimum length of 8!
:sweat_smile:
**Note**: The postinstall could still fail if the user uses a dictionary word or other common word, and I think checking if the password is from such a list would be out of scope...Install Party 16/02/2020https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/26Resolve "Issues with the cleanup function when aborting"2020-02-09T09:19:59ZHgOResolve "Issues with the cleanup function when aborting"Closes #24Closes #24Install Party 16/02/2020IljaIljahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/25Ignore verification of Yunohost GPG signature on import key failure2020-02-08T12:55:33ZHgOIgnore verification of Yunohost GPG signature on import key failureCloses #21Closes #21Install Party 16/02/2020https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/24Resolve "Add flag for dev questions"2020-02-08T12:55:45ZHgOResolve "Add flag for dev questions"Closes #19
Requires !23 to be merged first.
## Features
- Add the `-c` flag to include user's custom script
- Remove the questions about adding user's custom script
- Update help message for the `-c` flag
- Translate new strings in F...Closes #19
Requires !23 to be merged first.
## Features
- Add the `-c` flag to include user's custom script
- Remove the questions about adding user's custom script
- Update help message for the `-c` flag
- Translate new strings in FrenchInstall Party 16/02/2020IljaIljahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/23Include neutrinet specifics in general script2020-02-08T12:56:32ZIljaInclude neutrinet specifics in general scriptCloses #20
* Remove the custom neutrinet script thing
* Make sure the script creates it in the cube_resources folder and uses that oneCloses #20
* Remove the custom neutrinet script thing
* Make sure the script creates it in the cube_resources folder and uses that oneInstall Party 16/02/2020IljaIljahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/22Release changes for install party 19/01/20202020-01-19T11:59:07ZHgORelease changes for install party 19/01/2020Closes #18
# Release notes
* Pass verbose parameter to install-sd.sh script (!19, closes #15)
* Optionally import VPN certificates instead of copy/paste (!18, closes #14)
* Optionally clean up the cube_resources and install.hype...Closes #18
# Release notes
* Pass verbose parameter to install-sd.sh script (!19, closes #15)
* Optionally import VPN certificates instead of copy/paste (!18, closes #14)
* Optionally clean up the cube_resources and install.hypercube (!15 and !20, closes #13)
* Add French translations (!16, closes #10)
* Improve documentation (!21, closes #16)
# Testing
* [x] Check that the import of VPN certificates actually works (try with copy/paste, then with the import feature, and verify that both hypercube.install files are the same)
* [x] Check that resources are removed after cleanup (cube_resources and install.hypercube should be removed)
* [x] Check French translation and check if LANGUAGE parameter actually switches language
* [x] Check the `-v` option: it should toggle debug mode for install-sd.sh script as well
* [x] Check that the install succeed ^^https://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/21Improve the README.md2020-01-18T08:57:58ZIljaImprove the README.mdAdded
* What the script does (including what info is asked)
* How to download the script
* Change the structure a bit
Closes #16Added
* What the script does (including what info is asked)
* How to download the script
* Change the structure a bit
Closes #16IljaIljahttps://gitlab.domainepublic.net/Neutrinet/neutrinet_cube_install/-/merge_requests/20Improve sentence about keeping install.hypercube2020-01-18T08:51:18ZHgOImprove sentence about keeping install.hypercubeCloses #13
I did two things:
- Actually removing the `install.hypercube` file :sweat_smile:
- Improving the sentence about keeping this file
I didn't change the sentence in a positive way ("Do you want to keep this file ? (y)" when th...Closes #13
I did two things:
- Actually removing the `install.hypercube` file :sweat_smile:
- Improving the sentence about keeping this file
I didn't change the sentence in a positive way ("Do you want to keep this file ? (y)" when the script failed, and "Do you want to remove this file? (y)", when the script succeed), because I have the feeling it might confuse the reader (sometimes we skip words when reading, and the reader might think it was the same sentence as before, while it was the exact opposite)IljaIlja